Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'YOU ARE HERE' indicator in Kanvas, cloud documentation #458

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ShivprasadRoul
Copy link

[Docs] Fix "YOU ARE HERE" indicator in Kanvas documentation

Description

This PR fixes the "YOU ARE HERE" indicator in the Kanvas documentation page. The indicator was previously not rendering correctly and showing raw HTML code. Now it's properly implemented with the same styling as in the Cloud documentation, with capitalized "YOU ARE HERE" text as requested.

During the discussion about this issue, I was initially asked to replace the square with a pin icon, but after trying this approach, I found that it looked odd and negatively affected the layout. Instead, I implemented a solution that highlights the entire section with the same styling used in the Cloud documentation, which provides better visual indication and consistency across the docs.

As per Lee's feedback, I've made sure to capitalize the "YOU ARE HERE" text to maintain consistency with the Cloud documentation.

Before:
image
image

After:
image
image

Notes for Reviewers

This PR fixes #455

Signed commits

  • Yes, I signed my commits.

Copy link

netlify bot commented Mar 16, 2025

Deploy Preview for bejewelled-pegasus-b0ce81 ready!

Name Link
🔨 Latest commit d19016d
🔍 Latest deploy log https://app.netlify.com/sites/bejewelled-pegasus-b0ce81/deploys/67d68dae836c3d000853fa26
😎 Deploy Preview https://deploy-preview-458--bejewelled-pegasus-b0ce81.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vishalvivekm
Copy link
Contributor

@ShivprasadRoul
Thank you for your contribution!
Let's discuss this during the website call today at 5:30 PM IST

adding it as an agenda item to the meeting minutes.


**Layer5 Cloud** ([docs](/cloud)) is an identity provider and global console for Meshery deployments with an extensible and highly flexible authorization framework, tenant entitlement services, service provider-grade organizational hierarchy, team workspace management and a content catalog for public and private hosting of cloud native architectures. Layer5 Cloud is available as a service or self-hosted.
</div>
<div style="display:flex;flex-direction:column;margin-bottom:2rem;margin-top:1rem;padding:1rem;box-shadow:inset 0 0 4em #ebc01766,0 0 0 2px #ebc01766,.3em .3em 1em #ebc01733;position:relative;">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make all these repeated CSS, reusable.

@leecalcote
Copy link
Member

Thanks for working on this, @ShivprasadRoul!

@leecalcote leecalcote added the issue/dco One or more commits missing sign off. Commits need amended with sign off. label Mar 21, 2025
Copy link

🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address).

To amend the commits in this PR with your signoff using the instructions provided in the DCO check.

To configure your dev environment to automatically signoff on your commits in the future, see these instructions.


        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

@leecalcote
Copy link
Member

one-time instructions here - https://github.com/layer5io/docs/pull/458/checks?check_run_id=38840866547 - for amending commits, @ShivprasadRoul

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/cloud-docs component/kanvas-doc issue/dco One or more commits missing sign off. Commits need amended with sign off.
Development

Successfully merging this pull request may close these issues.

Replace 'You are here' Yellow Box with a Location Icon in Layer5 Docs
3 participants